Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update template with expresso/core and inversify #16

Merged
merged 2 commits into from
Apr 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 32 additions & 33 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -1,35 +1,34 @@
/* eslint-env node */
module.exports = {
extends: [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"eslint-config-prettier",
"prettier",
],
parser: "@typescript-eslint/parser",
parserOptions: {
project: ["./tsconfig.cjs.json", "./tsconfig.esm.json","./tsconfig.json"],
},
plugins: ["@typescript-eslint"],
root: true,
env: {
node: true,
jest: true,
},
ignorePatterns: [
"lib",
"node_modules",
".eslintrc.cjs",
"**/__tests__/*.spec.ts",
"vitest.config.ts",
],
rules: {
"@typescript-eslint/adjacent-overload-signatures": "error",
"@typescript-eslint/array-type": ["error", { default: "generic" }],
"@typescript-eslint/await-thenable": "error",
"@typescript-eslint/ban-types": "error",
"@typescript-eslint/class-literal-property-style": "error",
"@typescript-eslint/explicit-function-return-type": "error",
},
};

extends: [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"eslint-config-prettier",
"prettier",
],
parser: "@typescript-eslint/parser",
parserOptions: {
project: ["./tsconfig.cjs.json", "./tsconfig.esm.json", "./tsconfig.json"],
},
plugins: ["@typescript-eslint"],
root: true,
env: {
node: true,
jest: true,
},
ignorePatterns: [
"lib",
"node_modules",
".eslintrc.cjs",
"**/__tests__/*.spec.ts",
"vitest.config.ts",
],
rules: {
"@typescript-eslint/adjacent-overload-signatures": "error",
"@typescript-eslint/array-type": ["error", { default: "generic" }],
"@typescript-eslint/await-thenable": "error",
"@typescript-eslint/ban-types": "error",
"@typescript-eslint/class-literal-property-style": "error",
"@typescript-eslint/explicit-function-return-type": "error",
},
};
37 changes: 20 additions & 17 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,19 @@

Our guidelines for submitting a pull request.

## Before submitting a Pull Request, please make sure you have verified the following:
## Before submitting your PR, please verify the following:

- [ ] The commit message follows our guidelines:
- A good commit message should be two things: meaningful and concise. It should not contain every single detail, describing each changed line—we can see all the changes in Git—but, at the same time, it should say enough to avoid ambiguity.
- We use Microverse's commit message convention
- The convention stablish that a commit message has to be in the present tense, imperative and lowercase.
- Example: `fix typo in README.md`

> Make sure you prefix your commit message with the type of change you are making. Your commit message should look like this: `type: description of the change`.
>
> - Fixing a bug : `fix: description of the change`.
> - Adding a new feature : `feat: description of the change`.

See the options for the different types of changes you can make in the `package.json` file of your project.

**Leave the options below unchecked if they are not applicable to your Pull Request.**

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

Expand All @@ -17,31 +23,28 @@ Our guidelines for submitting a pull request.
What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Test
- [ ] Other... Please describe:

## What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: N/A

## What is the new behavior?

Describe the new behavior or link to a relevant issue.

## Does this PR introduce a breaking change?

- [ ] Yes
- [ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications below.
If `yes` Please describe the impact and mitigation strategy for existing applications.

## What was changed?

Please describe what you have changed in this PR.

## Other information

Any other information that is important to this PR.
Any other information that is important to this PR.
9 changes: 5 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"name": "@expressots/package-name",
"name": "@expressots/resend-provider",
"version": "0.0.1",
"description": "Expressots - modern, fast, lightweight nodejs web framework (@package-name)",
"author": "",
"description": "Expressots - Email using Resend Provider (@expressots/resend-provider)",
"author": "Richard Zampieri",
"main": "./lib/cjs/index.js",
"types": "./lib/cjs/types/index.d.ts",
"exports": {
Expand Down Expand Up @@ -67,13 +67,14 @@
"lint:fix": "eslint \"src/**/*.ts\" --fix"
},
"dependencies": {
"@expressots/core": "latest",
"inversify": "6.0.2",
"reflect-metadata": "0.2.2"
},
"devDependencies": {
"@codecov/vite-plugin": "0.0.1-beta.6",
"@commitlint/cli": "18.0.0",
"@commitlint/config-conventional": "17.7.0",
"@expressots/core": "latest",
"@release-it/conventional-changelog": "7.0.1",
"@types/node": "20.4.9",
"@typescript-eslint/eslint-plugin": "6.6.0",
Expand Down
2 changes: 2 additions & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
/* export your provider here */
//export * from "./your-provider";
22 changes: 6 additions & 16 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"compilerOptions": {
"strict": true,
"esModuleInterop": true,
"forceConsistentCasingInFileNames":true,
"forceConsistentCasingInFileNames": true,
"skipLibCheck": true,
"strictNullChecks": false,
"checkJs": true,
Expand All @@ -12,18 +12,8 @@
"allowSyntheticDefaultImports": true,
"experimentalDecorators": true,
"emitDecoratorMetadata": true,
"types": [
"node",
"reflect-metadata",
"vitest/globals"
],
},
"include": [
"src/**/*.ts"
],
"exclude": [
"node_modules",
"**/__tests__/*.spec.ts",
"scripts/**/*",
]
}
"types": ["node", "reflect-metadata", "vitest/globals"]
},
"include": ["src/**/*.ts"],
"exclude": ["node_modules", "**/__tests__/*.spec.ts", "scripts/**/*"]
}
Loading