Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crt and vhs shader brightness. #131

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cookiemonsternz
Copy link
Contributor

Just changed the brightness value, makes it look slightly worse on GitHub dark, but much better on all other themes.
Might be worth trying different brightness values and adjusting the pixel sizes for the shader, as when it is not overwhelmed with brightness it does look a little worse. Over around brightness 1.5 makes line numbers unreadable for GitHub light theme, however.

Github Dark Before:
image

Github Dark After:
image

One Dark Pro Darker Before:
image

One Dark Pro Darker After:
image

Github Light Before:
image

Github Light After:
image

Nord Before:
image

Nord After:
image

@TheMasterCoders
Copy link

Sacrifice of the GitHub Dark is required to let the rest get fixed if you choose to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants