Fix {fmt} breaking OSS build #636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As t_whisker_generator was introduced in bbbd038, it broke the OSS build with `error: ‘join’ is not a member of ‘fmt’`. The newer versions of {fmt} have `fmt::join` in `fmt/ranges.h`. Fixes: ``` thrift/compiler/generate/t_whisker_generator.cc:117:40: error: ‘join’ is not a member of ‘fmt’ 117 | "{}/{}", template_prefix, fmt::join(start, partial_path.end(), "/")); | ^~~~ ``` https://github.com/facebook/fbthrift/actions/runs/12822463794/job/35755425223
markbhasawut
force-pushed
the
fix-oss-build-fmt
branch
from
88235d1 to
9fbf38a
Compare
|
@yoney has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
merged, thanks! |
|
Thanks! |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jan 17, 2025
Summary:
As t_whisker_generator was introduced in bbbd038c9c5f2b1311e4d4d54c60fd022dc3ac19, it broke the OSS build with `error: ‘join’ is not a member of ‘fmt’`.
The newer versions of {fmt} have `fmt::join` in `fmt/ranges.h`.
Fixes:
```
thrift/compiler/generate/t_whisker_generator.cc:117:40: error: ‘join’ is not a member of ‘fmt’
117 | "{}/{}", template_prefix, fmt::join(start, partial_path.end(), "/"));
| ^~~~
```
https://github.com/facebook/fbthrift/actions/runs/12822463794/job/35755425223
X-link: facebook/fbthrift#636
Reviewed By: vitaut
Differential Revision: D68323045
Pulled By: yoney
fbshipit-source-id: 4280fa533d7e7e3efc3fbe0b080d40e18ade9dd8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As t_whisker_generator was introduced in bbbd038, it broke the OSS build with
error: ‘join’ is not a member of ‘fmt’.The newer versions of {fmt} have
fmt::joininfmt/ranges.h.Fixes:
https://github.com/facebook/fbthrift/actions/runs/12822463794/job/35755425223