Skip to content

Commit

Permalink
enable more brew system deps (#2219)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #2219

Save a bit of time on each github build. Enable homebrew system deps for fmt, gflags, glog, googletest, snappy

Reviewed By: chadaustin

Differential Revision: D57967014

fbshipit-source-id: 286ba96fb384e1b5e8f4e97160af2b801e458aef
  • Loading branch information
ahornby authored and facebook-github-bot committed Jun 3, 2024
1 parent 5d9c947 commit d186b26
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 0 deletions.
3 changes: 3 additions & 0 deletions build/fbcode_builder/manifests/fmt
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@ subdir = fmt-9.1.0
[cmake.defines]
FMT_TEST = OFF
FMT_DOC = OFF

[homebrew]
fmt
3 changes: 3 additions & 0 deletions build/fbcode_builder/manifests/gflags
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,8 @@ BUILD_STATIC_LIBS = ON
#BUILD_gflags_nothreads_LIB = OFF
BUILD_gflags_LIB = ON

[homebrew]
gflags

[debs]
libgflags-dev
3 changes: 3 additions & 0 deletions build/fbcode_builder/manifests/glog
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,8 @@ WITH_PKGCONFIG=ON
HAVE_TR1_UNORDERED_MAP=OFF
HAVE_TR1_UNORDERED_SET=OFF

[homebrew]
glog

[debs]
libgoogle-glog-dev
3 changes: 3 additions & 0 deletions build/fbcode_builder/manifests/googletest
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ gtest_force_shared_crt=ON
[cmake.defines.os=windows]
BUILD_SHARED_LIBS=ON

[homebrew]
googletest

# packaged googletest is too old
[debs.not(all(distro=ubuntu,any(distro_vers="18.04",distro_vers="20.04",distro_vers="22.04")))]
libgtest-dev
Expand Down
3 changes: 3 additions & 0 deletions build/fbcode_builder/manifests/snappy
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
[manifest]
name = snappy

[homebrew]
snappy

[debs]
libsnappy-dev

Expand Down

0 comments on commit d186b26

Please sign in to comment.