Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Closed] Fixed Before Input Event Bug #31957

Conversation

HitenChawda46
Copy link

@HitenChawda46 HitenChawda46 commented Jan 2, 2025

Summary

This PR fixes #24358
Registered onBeforeInput event with the dependency of including beforeinput instead of textInput, as beforeinput is an available native event, and ensured that beforeinput event is properly handled by dispatchQueue architecture flow

How did you test this change?

Ran test script and Manual Dev testing, and updated BeforeInputEventPlugin-test.js to ensure all tests are passing and covered

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 7:28pm

@HitenChawda46 HitenChawda46 force-pushed the HitenChawda46-before-input-event-bug-fix branch from ead1262 to 87f7976 Compare January 2, 2025 18:27
@HitenChawda46 HitenChawda46 changed the title fixed before input bug Fixed Before Input Event Bug Jan 2, 2025
@HitenChawda46 HitenChawda46 deleted the HitenChawda46-before-input-event-bug-fix branch January 3, 2025 19:47
@HitenChawda46 HitenChawda46 changed the title Fixed Before Input Event Bug F̶i̶x̶e̶d̶ B̶e̶f̶o̶r̶e̶ I̶n̶p̶u̶t̶ E̶v̶e̶n̶t̶ B̶u̶g̶ Jan 3, 2025
@HitenChawda46 HitenChawda46 changed the title F̶i̶x̶e̶d̶ B̶e̶f̶o̶r̶e̶ I̶n̶p̶u̶t̶ E̶v̶e̶n̶t̶ B̶u̶g̶ ~~Fixed Before Input Event Bug~~ Jan 3, 2025
@HitenChawda46 HitenChawda46 changed the title ~~Fixed Before Input Event Bug~~ [Closed] Fixed Before Input Event Bug Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: beforeInput event doesn't fire when input is replacing previous text
2 participants