[compiler] Fix invalid Array.map type #32095
Merged
+273
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
facebook-github-bot
added
CLA Signed
React Core Team
Small patch to pass aliased context values into `Object|ArrayExpression`s
See test fixture
See test fixture
josephsavona
approved these changes
Jan 21, 2025
|
Ahhh I see why this happened — note that the BuiltInArray methods already are marked as ConditionallyMutate. Its the copies of those declarations on the MixedReadonly type that were wrong. Before landing, can you please update all of the other relevant MixedReadonly methods to ConditionallyMutate? |
Done, thanks for catching these! I thought I checked the other MixedReadonlys before but completely missed |
mofeiZ
added a commit
that referenced
this pull request
Jan 22, 2025
Small patch to pass aliased context values into `Object|ArrayExpression`s --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32093). * #32099 * #32104 * #32098 * #32097 * #32096 * #32095 * #32094 * __->__ #32093
mofeiZ
added a commit
that referenced
this pull request
Jan 22, 2025
See test fixture --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32094). * #32099 * #32104 * #32098 * #32097 * #32096 * #32095 * __->__ #32094 * #32093
mofeiZ
added a commit
that referenced
this pull request
Jan 22, 2025
See title: this fixes test cases broken by #32095 adding instead of moving new test fixtures
mofeiZ
added a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See test fixture
Stack created with Sapling. Best reviewed with ReviewStack.