[compiler] Remove redundant InferMutableContextVariables #32097
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
| if ($[0] !== sharedVal) { | ||
| t0 = ( | ||
| <Button | ||
| onPress={() => (sharedVal.value = Math.random())} |
There was a problem hiding this comment.
seems like the check wasn't completely redundant since we are getting different output. why does this output change exactly?
There was a problem hiding this comment.
This is a similar case to the other test fixture (which also had changed output). From my opinion, we should be able to replace onPress={() => (sharedVal.value = Math.random())} with onPress={() => mutate(sharedVal)}, without meaningful changes to mutability inference.
This isn't the case today. InferMutableContextVariables annotates sharedVal has having a (known) "write", only because it sees a PropertyStore instruction. Without this, we infer sharedVal as only being captured by the function. This distinction doesn't really make sense with enableTransitivelyFreezeFunctionExpressions mode
There was a problem hiding this comment.
Ahhh makes sense. Cool
Small patch to pass aliased context values into `Object|ArrayExpression`s --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32093). * #32099 * #32104 * #32098 * #32097 * #32096 * #32095 * #32094 * __->__ #32093
See test fixture --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32094). * #32099 * #32104 * #32098 * #32097 * #32096 * #32095 * __->__ #32094 * #32093
See test fixture --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32095). * #32099 * #32104 * #32098 * #32097 * #32096 * __->__ #32095 * #32094 * #32093
LoweredFunction dependencies were exclusively used for dependency extraction (in `propagateScopeDeps`). Now that we have a `propagateScopeDepsHIR` that recursively traverses into nested functions, we can delete `dependencies` and their associated synthetic `LoadLocal`/`PropertyLoad` instructions.
This removes special casing for `PropertyStore` mutability inference within FunctionExpressions.
This removes special casing for
PropertyStoremutability inference within FunctionExpressions.Stack created with Sapling. Best reviewed with ReviewStack.