Remove wall time from BM report #10829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
assignUser
added
the
ready-to-merge
kgpai
approved these changes
Aug 27, 2024
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Sep 2, 2024
Summary: The method I used to get the wall time is brittle against changes in the ninja log layout (e.g. through cmake or ninja updates) and currently making the plots useless due to an underflow. - remove wall time from plots - no longer track wall time Pull Request resolved: facebookincubator#10829 Reviewed By: DanielHunte Differential Revision: D61862320 Pulled By: kgpai fbshipit-source-id: 310d26e09c9317759c4c7733eb6041c504589db7
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Sep 3, 2024
Summary: The method I used to get the wall time is brittle against changes in the ninja log layout (e.g. through cmake or ninja updates) and currently making the plots useless due to an underflow. - remove wall time from plots - no longer track wall time Pull Request resolved: facebookincubator#10829 Reviewed By: DanielHunte Differential Revision: D61862320 Pulled By: kgpai fbshipit-source-id: 310d26e09c9317759c4c7733eb6041c504589db7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method I used to get the wall time is brittle against changes in the ninja log layout (e.g. through cmake or ninja updates) and currently making the plots useless due to an underflow.