Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wall time from BM report #10829

Closed
wants to merge 3 commits into from
+3 −3
Closed

Remove wall time from BM report #10829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbf5aa1
exclude wall time from plots
assignUser Aug 24, 2024
30090a0
no longer track wall time
assignUser Aug 24, 2024
89d12b9
add report files to workflow trigger
assignUser Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build-metrics.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ on:
pull_request:
paths:
- ".github/workflows/build-metrics.yml"
- "script/bm-report/**"

workflow_dispatch:
inputs:
Expand Down
2 changes: 1 addition & 1 deletion scripts/bm-report/report.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ format_tags <- function(x) {
```{r total-graphs}
# Filter the data and layout the overview plots
times_plot <- results |>
filter(tags.suite == "total", endsWith(tags.source, "time")) |>
filter(tags.suite == "total", endsWith(tags.source, "time"), tags.name != "wall_time") |>
mutate(
stats.data = lubridate::dseconds(stats.data),
tags.name = format_tags(tags.name)
Expand Down
3 changes: 1 addition & 2 deletions scripts/build-metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def _transform_results(self) -> List[BenchmarkResult]:
class NinjaLogAdapter(BenchmarkAdapter):
"""
Adapter to extract compile and link times from a .ninja_log.
Will calculate aggregates for total, compile, link and wall time.
Will calculate aggregates for total, compile and link time.
Suite metadata will be set based on binary ending to object, library or executable.

Only files in paths beginning with velox/ will be tracked to avoid dependencies.
Expand Down Expand Up @@ -135,7 +135,6 @@ def _transform_results(self) -> List[BenchmarkResult]:
"link_time": 0,
"compile_time": 0,
"total_time": 0,
"wall_time": get_epoch(log_lines[-1]) - get_epoch(log_lines[0]),
}

for line in log_lines:
Expand Down