Move signature check and bias fuzzer to gha #9191
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
assignUser
force-pushed
the
bias-fuzzer-gha
branch
from
d35e842 to
0eca346
Compare
assignUser
force-pushed
the
bias-fuzzer-gha
branch
2 times, most recently
from
c39e840 to
789e697
Compare
assignUser
force-pushed
the
bias-fuzzer-gha
branch
from
04b49d9 to
5987b92
Compare
assignUser
changed the title
assignUser
force-pushed
the
bias-fuzzer-gha
branch
2 times, most recently
from
9b79e81 to
07e1e87
Compare
|
@kgpai the bias fuzzer/signature check stuff works now. |
|
Thanks for the changes @assignUser |
|
I reverted the test changes, this should be ready to go now! I also removed the remaining cci bits. I will cleanup scripts/ in a follow up. |
| @@ -527,3 +635,21 @@ jobs: | |||
| path: | | |||
| /tmp/aggregate_fuzzer_repro | |||
| /tmp/server.log | |||
|
|
|||
| surface-signature-errors: | |||
There was a problem hiding this comment.
Does this need to be separate workflow, cant we do it at the end of the failing workflow ?
There was a problem hiding this comment.
This is meant to surface the issue quickly (e.g. in case it wasn't intentional), if we add it to the bias fuzzer it will show up an hour later. The job takes a few seconds so it's not like it costs anything ^^
This reverts commit 9123524.
assignUser
force-pushed
the
bias-fuzzer-gha
branch
from
a233b70 to
af26c25
Compare
| ./velox_expression_fuzzer_test \ | ||
| --seed ${RANDOM} \ | ||
| --lazy_vector_generation_ratio 0.2 \ | ||
| --assign_function_tickets $(cat /tmp/signatures/presto_bias_functions) \ |
There was a problem hiding this comment.
what if presto_bias_functions is empty - shouldnt there be a check above ?
There was a problem hiding this comment.
An empty file will not be created due to this. And thus this step won't run. Previously an empty file might have been created due to the way argsparse.FileType works (it opens the file when the args are parsed) but I removed that.
|
Can you make the circleci configuration empty , or a no/op ? This is because currently it shows an error if there is no configuration. I will request a deactivation of cci and then I can remove it. |
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Summary: Move the signature check and bias fuzzer from CCI to GHA. Pull Request resolved: facebookincubator#9191 Reviewed By: Yuhta Differential Revision: D55599384 Pulled By: kgpai fbshipit-source-id: b998a064319f451ebe2d3508f3dbca3d165a669a
Summary: Move the signature check and bias fuzzer from CCI to GHA. Pull Request resolved: facebookincubator#9191 Reviewed By: Yuhta Differential Revision: D55599384 Pulled By: kgpai fbshipit-source-id: b998a064319f451ebe2d3508f3dbca3d165a669a
Move the signature check and bias fuzzer from CCI to GHA.