Use singleton per-region for S3Client #384
Conversation
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39174441 |
Summary: Pull Request resolved: facebookresearch#384 # What * Use a singleton for each region when constructing our S3Client instead of a _single_ singleton * This is kind of a follow-up to D36727729 (facebookresearch@47182c6) # Why * Follow-up to S281873 - S3Client singleton breaks multi-region support in PCF IO NOTE: PCF should be owning this code in the long-term since it's out of PSI's scope, but since we owned the initial SEV, I took ownership of this follow-up. Differential Revision: D39174441 fbshipit-source-id: 73dd6d6c88e216da3f99573689ef4c4eaa7d16ed
gorel
force-pushed
the
export-D39174441
branch
from
944238e
to
7854242
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39174441 |
Summary: Pull Request resolved: facebookresearch#384 # What * Use a singleton for each region when constructing our S3Client instead of a _single_ singleton * This is kind of a follow-up to D36727729 (facebookresearch@47182c6) # Why * Follow-up to S281873 - S3Client singleton breaks multi-region support in PCF IO NOTE: PCF should be owning this code in the long-term since it's out of PSI's scope, but since we owned the initial SEV, I took ownership of this follow-up. Differential Revision: D39174441 fbshipit-source-id: a44d96b31a140ed2a220d516dfbda74504bed7f7
gorel
force-pushed
the
export-D39174441
branch
from
7854242
to
6a3db69
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39174441 |
|
Hi @gorel! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Summary:
What
Why
NOTE: PCF should be owning this code in the long-term since it's out of PSI's scope, but since we owned the initial SEV, I took ownership of this follow-up.
Differential Revision: D39174441