Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use singleton per-region for S3Client #384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use singleton per-region for S3Client #384

wants to merge 1 commit into from

Commits on Sep 13, 2022

  1. Use singleton per-region for S3Client (facebookresearch#384) 

    Summary:
Pull Request resolved: facebookresearch#384

# What
* Use a singleton for each region when constructing our S3Client instead of a _single_ singleton
* This is kind of a follow-up to D36727729 (facebookresearch@47182c6)
# Why
* Follow-up to S281873 - S3Client singleton breaks multi-region support in PCF IO

NOTE: PCF should be owning this code in the long-term since it's out of PSI's scope, but since we owned the initial SEV, I took ownership of this follow-up.

Differential Revision: D39174441

fbshipit-source-id: a44d96b31a140ed2a220d516dfbda74504bed7f7
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    6a3db69 View commit details
    Browse the repository at this point in the history