-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(falco): add append_output configuration option with fields and format #3308
new(falco): add append_output configuration option with fields and format #3308
Conversation
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
/milestone 0.39.0 |
The structure and functionality is there and can be reviewed, I need to figure out how to properly add this to the json schema, make sure integration tests pass and add an explanation to |
/cc @incertum |
462c5f9
to
db8b078
Compare
I have updated the PR:
|
db8b078
to
0a65d01
Compare
This fixes the |
700a492
to
7fc21ec
Compare
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]> Co-authored-by: Federico Di Pierro <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
7b41d6d
to
c481491
Compare
Addressed @FedeDP 's comment, updated the json schema and also added a test for CLI options since the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 04ed804283cb84988ae80420bf2bd60f16d1f84b
|
false positive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits
# If none of the above are specified output is appended to all events, if more than one is | ||
# specified output will be appended to events that match all conditions. | ||
# And several options to add output: | ||
# `format`: add output to the Falco message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# `format`: add output to the Falco message | |
# `format`: format the given string and append it to the Falco output message |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This addresses the need for a configuration option that allows to specify:
This is how it works
Which issue(s) this PR fixes:
Fixes #3235
Special notes for your reviewer:
As a bonus, this gets rid of JsonCpp in Falco.
Does this PR introduce a user-facing change?: