Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(userspace/libsinsp/filter/parser): update grammar doc #2237

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

leogr
Copy link
Member

@leogr leogr commented Jan 16, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

I just added missing operators and alphabetically sorted them.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
/milestone 0.20.0
cc @jasondellaluce @LucaGuerra @FedeDP

Does this PR introduce a user-facing change?:

NONE

@poiana poiana added this to the 0.20.0 milestone Jan 16, 2025
@poiana poiana added kind/documentation Improvements or additions to documentation dco-signoff: no area/libsinsp labels Jan 16, 2025
@poiana poiana added the size/S label Jan 16, 2025
@poiana poiana requested a review from hbrueckner January 16, 2025 09:56
@leogr leogr requested a review from LucaGuerra January 16, 2025 09:56
FedeDP
FedeDP previously approved these changes Jan 16, 2025
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thank you very much!

@FedeDP
Copy link
Contributor

FedeDP commented Jan 16, 2025

Uh there is a conflict :/

Copy link

Perf diff from master - unit tests

     8.93%     -0.73%  [.] sinsp_evt::get_type
     9.52%     +0.65%  [.] sinsp_parser::reset
     1.22%     +0.39%  [.] libsinsp::sinsp_suppress::process_event
     3.16%     -0.30%  [.] sinsp_parser::process_event
     0.86%     -0.28%  [.] std::_Hashtable<conversion_key, std::pair<conversion_key const, conversion_info>, std::allocator<std::pair<conversion_key const, conversion_info> >, std::__detail::_Select1st, std::equal_to<conversion_key>, std::hash<conversion_key>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_find_before_node
     1.11%     +0.27%  [.] std::_Hashtable<unsigned long, std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> >, std::allocator<std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> > >, std::__detail::_Select1st, std::equal_to<unsigned long>, std::hash<unsigned long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     3.56%     -0.26%  [.] sinsp_evt::load_params
     6.02%     -0.26%  [.] next_event_from_file
     1.02%     -0.24%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     1.33%     +0.24%  [.] sinsp::fetch_next_event

Heap diff from master - unit tests

peak heap memory consumption: -5.18K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0160         +0.0160           148           151           148           151
BM_sinsp_split_median                                          +0.0131         +0.0132           148           150           148           150
BM_sinsp_split_stddev                                          +1.1751         +1.1751             1             2             1             2
BM_sinsp_split_cv                                              +1.1408         +1.1408             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0357         +0.0357            57            59            57            59
BM_sinsp_concatenate_paths_relative_path_median                +0.0345         +0.0346            57            59            57            59
BM_sinsp_concatenate_paths_relative_path_stddev                +1.0681         +1.0717             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.9969         +1.0003             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0136         -0.0136            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   -0.0130         -0.0130            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.3887         -0.3883             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.3802         -0.3799             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1353         +0.1353            56            63            56            63
BM_sinsp_concatenate_paths_absolute_path_median                +0.1330         +0.1331            56            63            56            63
BM_sinsp_concatenate_paths_absolute_path_stddev                +2.0941         +2.0887             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +1.7254         +1.7207             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0022         -0.0021           391           390           391           390
BM_sinsp_split_container_image_median                          -0.0024         -0.0024           390           389           390           389
BM_sinsp_split_container_image_stddev                          +0.5606         +0.5604             3             4             3             4
BM_sinsp_split_container_image_cv                              +0.5639         +0.5638             0             0             0             0

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.11%. Comparing base (bceb3b1) to head (1769e54).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2237   +/-   ##
=======================================
  Coverage   75.11%   75.11%           
=======================================
  Files         276      276           
  Lines       34395    34395           
  Branches     5923     5923           
=======================================
  Hits        25836    25836           
  Misses       8559     8559           
Flag Coverage Δ
libsinsp 75.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8e1b1a3 into falcosecurity:master Jan 16, 2025
49 checks passed
@FedeDP FedeDP mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants