chore(libsinsp/runc): report correct container id with short cid

[therealbobo]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[FedeDP]

/approve

[poiana]

LGTM label has been added.

Git tree hash: 055aac84e7b646cd1c75d4d3e4300f32cf97f47f

[FedeDP]

/milestone 0.20.0

[github-actions]

Perf diff from master - unit tests

     9.55%     +0.81%  [.] sinsp_parser::reset
     2.69%     +0.72%  [.] sinsp_thread_manager::get_thread_ref
     6.04%     -0.44%  [.] next_event_from_file
     3.57%     +0.42%  [.] sinsp_evt::load_params
     3.18%     -0.37%  [.] sinsp_thread_manager::find_thread
     3.17%     -0.32%  [.] sinsp_parser::process_event
     1.02%     -0.30%  [.] sinsp_evt::get_direction
     1.99%     +0.28%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     3.99%     -0.28%  [.] gzfile_read
     1.09%     +0.25%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>

Heap diff from master - unit tests

peak heap memory consumption: -5.18K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0117         +0.0117           148           150           148           150
BM_sinsp_split_median                                          +0.0132         +0.0133           148           150           148           150
BM_sinsp_split_stddev                                          +0.5093         +0.5104             1             2             1             2
BM_sinsp_split_cv                                              +0.4918         +0.4929             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0789         +0.0789            57            61            57            61
BM_sinsp_concatenate_paths_relative_path_median                +0.0794         +0.0795            57            61            57            61
BM_sinsp_concatenate_paths_relative_path_stddev                +0.0027         +0.0042             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.0705         -0.0692             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0450         -0.0449            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0454         -0.0454            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.3069         -0.3063             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.2742         -0.2736             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1356         +0.1356            56            63            56            63
BM_sinsp_concatenate_paths_absolute_path_median                +0.1362         +0.1362            56            63            56            63
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.2065         +0.2040             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.0624         +0.0602             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0022         +0.0022           391           391           391           391
BM_sinsp_split_container_image_median                          +0.0040         +0.0040           390           392           390           392
BM_sinsp_split_container_image_stddev                          -0.2990         -0.2990             3             2             3             2
BM_sinsp_split_container_image_cv                              -0.3005         -0.3005             0             0             0             0

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.11%. Comparing base (bceb3b1) to head (769057f).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2238   +/-   ##
=======================================
  Coverage   75.11%   75.11%           
=======================================
  Files         276      276           
  Lines       34395    34394    -1     
  Branches     5923     5922    -1     
=======================================
  Hits        25836    25836           
+ Misses       8559     8558    -1     

Flag	Coverage Δ
libsinsp	75.11% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[therealbobo]

/hold

[poiana]

LGTM label has been added.

Git tree hash: 92f54c77cb65f8af0ea0fbc6e0da0ac70cd22288

[therealbobo]

/unhold

[FedeDP]

/approve

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment