Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: plugin rules contains a semver required engine version and also new artifacts config layer #373

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

loresuso
Copy link
Member

@loresuso loresuso commented Nov 2, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:
Find more details here falcosecurity/falco#2899

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@loresuso loresuso force-pushed the engine-version-semver branch from 25ca6ec to efdd652 Compare November 2, 2023 16:55
… rulesfiles artifact configs

Signed-off-by: Lorenzo Susini <[email protected]>
@loresuso loresuso force-pushed the engine-version-semver branch from efdd652 to 31d4544 Compare November 2, 2023 16:59
@leogr
Copy link
Member

leogr commented Nov 8, 2023

This PR is ok for me. However, if we merge this now, we won't be able to release plugin patches that work with the current Falco version.

So, hold for now.
/hold

@loresuso
Copy link
Member Author

loresuso commented Jan 8, 2024

Reminder: this PR has to be merged before releasing plugins for the incoming Falco release

@leogr
Copy link
Member

leogr commented Jan 9, 2024

Reminder: this PR has to be merged before releasing plugins for the incoming Falco release

We will merge this soon and re-release all plugins close to the Falco release (due by the end of this month).

cc @LucaGuerra

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@poiana
Copy link
Contributor

poiana commented Jan 16, 2024

LGTM label has been added.

Git tree hash: e3b5e5f2b16e6194b2dd334b1614d26f8905485e

@poiana
Copy link
Contributor

poiana commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit eaa8fb1 into falcosecurity:master Jan 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants