Add support for Django 3.2 #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merwok
reviewed
May 4, 2022
tests/testapp/tests.py
Outdated
| """ | ||
| Test that the admin autocomplete endpoint loads. | ||
| Test that the admin autocomplete endpoint loads on Django 3.2 and before. |
There was a problem hiding this comment.
these docstrings have been switched
There was a problem hiding this comment.
Have they? This test is skipped if Django >= 3.2, so that's for 3.1 and earlier... Let me know if I'm missing something!
This docstring is still wrong, this test doesn't actually include 3.2, it should be <3.2 not <=3.2 🤦🏻
I'll update the reason in the skipIf decorator as it's a bit redundant.
There was a problem hiding this comment.
blep, it was me reading it wrong (skip if, not run if!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top #72 to run tests against Django 3.2 and declare support.