-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Django 3.2 #78
Open
browniebroke
wants to merge
6
commits into
farhan0581:pre_release
Choose a base branch
from
browniebroke:ci/django-3.2
base: pre_release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6cd43a1
Create workflow to run tests using GitHub actions
browniebroke ecb1c2a
Update trove classifiers to reflect Ci
browniebroke 50f7d30
Simplify Django version in GH workflow
browniebroke 9b53800
Update Trove classifiers
browniebroke a455901
Add support for Django 3.2
browniebroke 91ce835
Fix docstrings and clarify skip reason in tests
browniebroke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
name: Tests | ||
|
||
on: | ||
push: | ||
pull_request: | ||
|
||
jobs: | ||
test: | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
versions: | ||
- python: "3.6" | ||
django: "2.0" | ||
- python: "3.6" | ||
django: "2.1" | ||
- python: "3.6" | ||
django: "2.2" | ||
- python: "3.6" | ||
django: "3.1" | ||
- python: "3.6" | ||
django: "3.2" | ||
|
||
- python: "3.7" | ||
django: "2.0" | ||
- python: "3.7" | ||
django: "2.1" | ||
- python: "3.7" | ||
django: "2.2" | ||
- python: "3.7" | ||
django: "3.1" | ||
- python: "3.7" | ||
django: "3.2" | ||
|
||
- python: "3.8" | ||
django: "2.2" | ||
- python: "3.8" | ||
django: "3.1" | ||
- python: "3.8" | ||
django: "3.2" | ||
|
||
- python: "3.9" | ||
django: "2.2" | ||
- python: "3.9" | ||
django: "3.1" | ||
- python: "3.9" | ||
django: "3.2" | ||
|
||
name: "Python ${{ matrix.versions.python }} - Django ${{ matrix.versions.django }}" | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: ${{ matrix.versions.python }} | ||
- name: Install Dependencies | ||
run: pip install "Django~=${{ matrix.versions.django }}.0" | ||
- name: Run Tests | ||
run: ./tests_manage.py test tests |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these docstrings have been switched
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have they? This test is skipped if Django >= 3.2, so that's for 3.1 and earlier... Let me know if I'm missing something!
This docstring is still wrong, this test doesn't actually include 3.2, it should be <3.2 not <=3.2 🤦🏻
I'll update the reason in the
skipIf
decorator as it's a bit redundant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blep, it was me reading it wrong (skip if, not run if!)