-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom fields checkbox list #1318
Fix custom fields checkbox list #1318
Conversation
stanleylhs
commented
Aug 6, 2024
•
edited by steveyken
Loading
edited by steveyken
- Fix error when saving custom fields checkbox list (YAML serialization is not required on the form)
- Removed obselete "checkbox" field code in render method. This was legacy code.
- Added warning to restart Rails server as 'Checkbox list' custom field serialization must apply to all instances of Rails (eager load issue).
New checkbox list need serialization thus restarting the server is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing tests
I'm happy to dig into this in a couple of weeks time. |
) | ||
object = double('Object') | ||
context "render" do | ||
let(:field) { FactoryBot.create(:field, as: as) } |
Check notice
Code scanning / Rubocop
Prefer Ruby 1.9 hash syntax { a: 1, b: 2 } over 1.8 syntax { :a => 1, :b => 2 }. Note test
end | ||
end | ||
|
Check notice
Code scanning / Rubocop
Keeps track of empty lines around block bodies. Note test
I've re-written the failing specs to ensure this is working properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've improved the specs and tested the changes locally. This will fix the checkbox list form rendering