Fix custom fields checkbox list

app/models/fields/field.rb

@@ -34,7 +34,7 @@ class Field < ActiveRecord::Base
   serialize :collection, Array
   serialize :settings, HashWithIndifferentAccess
 
-  belongs_to :field_group, optional: true # TODO: Is this really optional?
+  belongs_to :field_group, optional: true
 
   scope :core_fields,   -> { where(type: 'CoreField') }
   scope :custom_fields, -> { where("type != 'CoreField'") }
@@ -92,8 +92,6 @@ def render_value(object)
 
   def render(value)
     case as
-    when 'checkbox'
-      value.to_s == '0' ? "no" : "yes"
     when 'date'
       value&.strftime(I18n.t("date.formats.mmddyy"))
     when 'datetime'

app/views/admin/custom_fields/_check_boxes_field.html.haml

@@ -1,6 +1,9 @@
 %div
   .label.top.req
     = "Select Options (pipe separated):"
-= f.text_field :collection_string, class: 'field_collection_string', size: 78
+= f.text_field :collection_string, class: 'field_collection_string', size: 78, placeholder: "Option 1|Option 2|Option 3"
 
 = render partial: 'admin/custom_fields/base_field', locals: {f: f}
+
+- if f.object.new_record?
+  .info2 After saving, you must restart all instances of the Rails server to apply column serialization.

app/views/fields/_group_table.html.haml

@@ -5,11 +5,8 @@
         %td{class: (f.object.errors[field.name].present? ? 'fieldWithErrors' : nil)}
           - if field.hint.present?
             = image_tag "info_tiny.png", title: field.hint, class: "tooltip-icon"
-          - if field.as == 'check_boxes'
-            - value = f.object.send(field.name)
-            - checked = YAML.load(value.to_s)
           .label.top{class: (field.required? ? 'req': nil)}
             = "#{field.label}:"
-          = f.input_field field.name, field.input_options.merge(checked: checked)
+          = f.input_field field.name, field.input_options
         - if i == 0
           %td= spacer

spec/models/fields/field_spec.rb

@@ -49,21 +49,24 @@
     expect(Field.new.input_options).to be_a(Hash)
   end
 
-  it "should be able to display a empty multi_select value" do
-    field = Field.new(
-      label: "Availability",
-      name:  "availability"
-    )
-    object = double('Object')
+  context "render" do
+    let(:field) { FactoryBot.create(:field, as: as) }
+
+    context "check_boxes" do
+      let(:as) { "check_boxes" }
+      it { expect(field.render([1, 2, 3])).to eql("1, 2<br />3") }
+      it { expect(field.render([1, 2, 3])).to eql("1, 2<br />3") }
+    end
 
-    #  as  |  value  |  expected
-    [["check_boxes", [1, 2, 3], "1, 2<br />3"],
-     %w[checkbox 0 no],
-     ["checkbox", 1, "yes"],
-     ["date", Time.parse('2011-04-19'), Time.parse('2011-04-19').strftime(I18n.t("date.formats.mmddyy"))]].each do |as, value, expected|
-      field.as = as
-      allow(object).to receive(field.name).and_return(value)
-      expect(field.render_value(object)).to eq(expected)
+    context "date" do
+      let(:as) { "date" }
+      it { expect(field.render(Time.parse('2011-04-19'))).to eql("Apr 19, 2011") }
+    end
+
+    context "datetime" do
+      let(:as) { "datetime" }
+      it { expect(field.render(Time.parse('2011-04-19 14:47 +0000'))).to eql("19 Apr 2011 at  2:47PM") }
     end
   end
+
 end