Reboot with TDD to get this up to speed #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this seems significantly less noisy and generally easier to scan the implementation could likely be improved WRT elegance and efficiency
while syntactically this might look more complicated, it's actually more explicit and thus easier to understand (less context required)
this also resulted in a `Page` rewrite TDD FTW!
the primary purpose here was to make URIs configurable (i.e. customizing mount points, avoiding hard-coded expectations), but this is also useful for encapsulation and generally tying things together (notably managing page hierarchies, but eventually also dispatching rendering)
NB: this does not yet include HTML generation and also omits both site
metadata (which currently resides in `faucet.config.js`) and
complate support
note that because HTML rendering is still missing, this isn't actually usable yet
moonglum
commented
Nov 14, 2018
moonglum
commented
Nov 14, 2018
moonglum
commented
Nov 14, 2018
moonglum
commented
Nov 14, 2018
moonglum
commented
Nov 14, 2018
moonglum
commented
Nov 14, 2018
FND
reviewed
Nov 14, 2018
FND
reviewed
Nov 14, 2018
FND
reviewed
Nov 14, 2018
FND
reviewed
Nov 14, 2018
FND
reviewed
Nov 14, 2018
FND
reviewed
Nov 14, 2018
Use an NPM package for it, because the standard library doesn't offer anything for that...
moonglum
commented
Nov 14, 2018
moonglum
commented
Nov 14, 2018
moonglum
commented
Nov 15, 2018
|
@FND Navigation is now implemented, feedback welcome. |
FND
reviewed
Nov 16, 2018
FND
reviewed
Nov 16, 2018
FND
reviewed
Nov 16, 2018
FND
reviewed
Nov 16, 2018
FND
reviewed
Nov 16, 2018
|
Thanks for your work and your feedback, @FND |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains structural improvements and tests based upon changes by @FND. Follow up after this PR:
_reportmethod #18: Expose areportfunction as a helper in faucet-pipeline-core and use it here instead of the private method.