Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reboot with TDD to get this up to speed #13

Merged
merged 23 commits into from
Nov 19, 2018
Merged

Reboot with TDD to get this up to speed #13

merged 23 commits into from
Nov 19, 2018

Commits on Nov 12, 2018

  1. Simplify pages' configuration format

    this seems significantly less noisy and generally easier to scan
    
    the implementation could likely be improved WRT elegance and efficiency
    FND committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    e2a50a8 View commit details
    Browse the repository at this point in the history
  2. Simplify internals by avoiding excessive asset-manager references

    while syntactically this might look more complicated, it's actually more
    explicit and thus easier to understand (less context required)
    FND committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    264cf4b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    328b26b View commit details
    Browse the repository at this point in the history
  4. Create abstraction for page hierarchies

    this also resulted in a `Page` rewrite
    
    TDD FTW!
    FND committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    d069aea View commit details
    Browse the repository at this point in the history
  5. Create abstraction for sites (i.e. styleguide instances)

    the primary purpose here was to make URIs configurable (i.e. customizing
    mount points, avoiding hard-coded expectations), but this is also useful
    for encapsulation and generally tying things together (notably managing
    page hierarchies, but eventually also dispatching rendering)
    FND committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    ac689aa View commit details
    Browse the repository at this point in the history
  6. Generate site structure

    NB: this does not yet include HTML generation and also omits both site
        metadata (which currently resides in `faucet.config.js`) and
        complate support
    FND committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    b5143e3 View commit details
    Browse the repository at this point in the history
  7. Replace obsolete implementation

    note that because HTML rendering is still missing, this isn't actually
    usable yet
    FND committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    d051bb9 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2018

  1. Restoring functionality

    moonglum committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    508fe5c View commit details
    Browse the repository at this point in the history
  2. Delete generated files in node

    Use an NPM package for it, because the standard library doesn't offer
    anything for that...
    moonglum committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    2e95dba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    268326f View commit details
    Browse the repository at this point in the history
  4. Renamed examples to snippets

    moonglum committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    dcafccf View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a5f6992 View commit details
    Browse the repository at this point in the history
  6. Rename file

    moonglum committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    29bf668 View commit details
    Browse the repository at this point in the history
  7. Report writing files

    moonglum committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    20c6e72 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6db1f5e View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2018

  1. Configuration menu
    Copy the full SHA
    7a189f8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7cc4466 View commit details
    Browse the repository at this point in the history
  3. 1 Configuration menu
    Copy the full SHA
    c10ccbd View commit details
    Browse the repository at this point in the history
  4. Cleanup

    moonglum committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    c7bebc8 View commit details
    Browse the repository at this point in the history
  5. Cleanup faucet.config.js

    moonglum committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    e23054c View commit details
    Browse the repository at this point in the history
  6. Add tests for PageRenderer

    moonglum committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    d323188 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2018

  1. Configuration menu
    Copy the full SHA
    eab05ef View commit details
    Browse the repository at this point in the history
  2. Generate the navigation

    moonglum committed Nov 16, 2018
    Configuration menu
    Copy the full SHA
    270fadf View commit details
    Browse the repository at this point in the history