ADX-949 ADX-958 ckanext-validation upgrade #271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
helpers.py:get_schema_filepath()
helpers.py:validation_load_json_schema()
ckanext.validation.schema_directory
config tockanext.unaids.schema_directory
.before_create()
hook to overload the upstream schema processing, this allows us to just pass a schema nameafter_create()
andafter_update()
hooksIncludes the following PR:
Comparison between fjelltopp/ckanext-validation@development and frictionlessdata/[email protected] for context can be found here: fjelltopp/ckanext-validation@development...frictionlessdata:ckanext-validation:v2.0.0
Issue: https://fjelltopp.atlassian.net/browse/ADX-958
relates fjelltopp/adx_deploy#350
relates fjelltopp/adx_develop#132
relates fjelltopp/ckanext_validation#98 - including changes pushed upstream and Fjelltopp-specific patches
relates fjelltopp/unaids_data_specifications#58 - potential breaking change
Checklist