Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADX-949 ADX-958 ckanext-validation upgrade #271

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Conversation

ChasNelson1990
Copy link
Member

@ChasNelson1990 ChasNelson1990 commented Feb 9, 2023

Description

  • Ports over the following from our old ckanext-validation:
    • helpers.py:get_schema_filepath()
    • helpers.py:validation_load_json_schema()
  • Changes the ckanext.validation.schema_directory config to ckanext.unaids.schema_directory.
  • Modifies the before_create() hook to overload the upstream schema processing, this allows us to just pass a schema name
  • Moves the "validate whole package" logic into the after_create() and after_update() hooks
  • Brings the custom badges from our old ckanext-validation into this repo.

Includes the following PR:

Comparison between fjelltopp/ckanext-validation@development and frictionlessdata/[email protected] for context can be found here: fjelltopp/ckanext-validation@development...frictionlessdata:ckanext-validation:v2.0.0

Issue: https://fjelltopp.atlassian.net/browse/ADX-958

relates fjelltopp/adx_deploy#350
relates fjelltopp/adx_develop#132
relates fjelltopp/ckanext_validation#98 - including changes pushed upstream and Fjelltopp-specific patches
relates fjelltopp/unaids_data_specifications#58 - potential breaking change

Checklist

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.

@ChasNelson1990 ChasNelson1990 marked this pull request as ready for review August 8, 2023 09:49
@ChasNelson1990 ChasNelson1990 changed the title ADX-958 Make fjelltopp/ckanext-scheming compatible with upstream frictionless/ckanext-validation ADX-949 ADX-958 ckanext-validation upgrade Aug 8, 2023
@ChasNelson1990 ChasNelson1990 marked this pull request as draft August 8, 2023 09:51
@ChasNelson1990 ChasNelson1990 merged commit 8d6bcd0 into development Aug 8, 2023
@ChasNelson1990 ChasNelson1990 deleted the ADX-959 branch August 8, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants