ADX-960 ADX-959 ckanext-validation upgrade #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChasNelson1990
changed the title
17 tasks
|
Supersedes #56 |
This was referenced May 12, 2023
This was referenced Aug 8, 2023
ChasNelson1990
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here we make schemas compatible with new upstream ckanext-validation after foreign key validation has been enabled.
!BREAKING CHANGE!
Previously unaids_data_specifications used schema names for
schema["foreignKeys"][i]["reference"]["resource"]but this didn't generalise as it very much assumes our fork of ckanext-scheming. Instead, I changed this to use what we callresource_type... I think this has the pro that we won't have to update the our table_schemas if we updates our package_schemas - foreign keys will now always follow the package_schema whereas (theroretically) you could have had a table_schema with a foreign key using a different schema version than a package_schema, which seemed silly.Issue: https://fjelltopp.atlassian.net/browse/ADX-959
relates fjelltopp/adx_deploy#350
relates fjelltopp/adx_develop#132
relates fjelltopp/ckanext-validation#103 - including changes pushed upstream and Fjelltopp-specific patches
relates fjelltopp/ckanext-unaids#271 - Fjelltopp-specific logic and custom badges