Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permssions #4

Closed
wants to merge 2 commits into from
Closed

Fix permssions #4

wants to merge 2 commits into from

Conversation

bbhtt
Copy link

@bbhtt bbhtt commented Jul 4, 2022

Fixes #2

The app cannot display lyrics even without this patch: ** (com.github.naaando.lyrics:2): CRITICAL **: 09:01:18.895: lyrics_lyrics_service_request_lyric: assertion 'song != NULL' failed Probably naaando/lyrics#35 (comment)

To test:

  1. Start a music player with MPRIS notification (Amberol seems to be work)
  2. Start this app
  3. See that the screen changes to blank, I assume it is trying to display the lyrics but can't due to the issue linked above. Else the state is either Currently not playing or no player found. Since it's not possible to determine that it is working, please don;'t merge this right now.

@flathubbot
Copy link

Started test build 98817

@flathubbot
Copy link

Build 98817 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/96544/com.github.naaando.lyrics.flatpakref

"--socket=wayland",
"--socket=session-bus",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so what session name was this needed for?

@bbhtt bbhtt marked this pull request as draft September 25, 2023 04:08
@guihkx guihkx mentioned this pull request Oct 18, 2024
@bbhtt bbhtt closed this in #7 Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--socket=session-bus is an overly broad permission
3 participants