-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added panic recovery to software mutations flow just to be safe #26932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a neat pattern I didn't know go could do 👍
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26932 +/- ##
==========================================
- Coverage 64.01% 64.01% -0.01%
==========================================
Files 1701 1701
Lines 162246 162256 +10
Branches 4325 4325
==========================================
+ Hits 103857 103863 +6
- Misses 50328 50330 +2
- Partials 8061 8063 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated this fix by removing the bounds check for the Python for Windows mutator and passing in a version in tests that only had 2-3 version components. The test returned a CPE based on the unmodified version string without panicking, which is what I would expect. Yay for robustness!
Checklist for submitter
If some of the following don't apply, delete the relevant line.