Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added panic recovery to software mutations flow just to be safe #26932

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

jahzielv
Copy link
Contributor

@jahzielv jahzielv commented Mar 6, 2025

For #24784

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Added/updated automated tests
  • Manual QA for all new/changed functionality

@jahzielv jahzielv requested a review from a team as a code owner March 6, 2025 22:46
ksykulev
ksykulev previously approved these changes Mar 6, 2025
Copy link
Contributor

@ksykulev ksykulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a neat pattern I didn't know go could do 👍

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.01%. Comparing base (9d3398a) to head (8323712).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
server/vulnerabilities/nvd/cpe.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26932      +/-   ##
==========================================
- Coverage   64.01%   64.01%   -0.01%     
==========================================
  Files        1701     1701              
  Lines      162246   162256      +10     
  Branches     4325     4325              
==========================================
+ Hits       103857   103863       +6     
- Misses      50328    50330       +2     
- Partials     8061     8063       +2     
Flag Coverage Δ
backend 64.77% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated this fix by removing the bounds check for the Python for Windows mutator and passing in a version in tests that only had 2-3 version components. The test returned a CPE based on the unmodified version string without panicking, which is what I would expect. Yay for robustness!

@jahzielv jahzielv merged commit 32c5c47 into main Mar 7, 2025
32 checks passed
@jahzielv jahzielv deleted the 24784-versions-panic branch March 7, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants