[Property Editor] Launch from devtools_app instead or root
#8806
Conversation
| "name": "standalone_ui/property_editor_sidebar", | ||
| "request": "launch", | ||
| "type": "dart", | ||
| "program": "test/test_infra/scenes/standalone_ui/property_editor_sidebar.stager_app.g.dart", |
There was a problem hiding this comment.
won't this launch target only work now if you've opened the devtools_app folder directly in VS code? We still want this launch target to work if someone has opened the main devtools/ folder.
If this fixes a bug, then maybe we actually have a bug with how package roots are detected for the inspector?
There was a problem hiding this comment.
the problem may be that the tool/flutter-sdk directory is getting included in the inspector package roots detection (if that is the Flutter SDK being used to build your app)
There was a problem hiding this comment.
Hmm that likely is the problem, I see my pub root directories are:
Because tool/flutter-sdk is under dev/devtools, everything there is included. Deleting /Users/elliottbrooks/dev/devtools so that the only entry is /Users/elliottbrooks/dev/devtools/packages fixes this.
I'll add details to the bug, and just have this PR add the launch config to devtools_app (it was annoying anyways that I could only launch the property editor from devtools root)
There was a problem hiding this comment.
Oh actually I think I must have set that at some point 🤦♀️ When I delete both pub roots, and then use the auto-refresh button, it correctly adds only /Users/elliottbrooks/dev/devtools/packages. So I think we're okay here
Work towards #8802
Implementation widgets were being included in the Widget Inspector debugging the property editor. I believe this is because we were launching the stager app from outside the
devtools_apppackage, and the devtools root directory was included (includingtool/flutter-sdk)