Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Property Editor] Launch from devtools_app instead or root #8806

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[Property Editor] Launch from devtools_app instead or root #8806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f0f15c
Add property editor to devtools_app launch.json
elliette Jan 24, 2025
b9cf4be
Remove from root launch.json
elliette Jan 24, 2025
e678051
Add back to main launch.json
elliette Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@
"request": "launch",
"type": "dart",
"program": "packages/devtools_app/test/test_infra/scenes/standalone_ui/property_editor_sidebar.stager_app.g.dart",
"preLaunchTask": "Start DTD on Port 8500",
},
{
"name": "devtools_extensions: foo + sim",
Expand Down
7 changes: 7 additions & 0 deletions packages/devtools_app/.vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,12 @@
"type": "dart",
"request": "attach",
},
{
"name": "standalone_ui/property_editor_sidebar",
"request": "launch",
"type": "dart",
"program": "test/test_infra/scenes/standalone_ui/property_editor_sidebar.stager_app.g.dart",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't this launch target only work now if you've opened the devtools_app folder directly in VS code? We still want this launch target to work if someone has opened the main devtools/ folder.

If this fixes a bug, then maybe we actually have a bug with how package roots are detected for the inspector?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem may be that the tool/flutter-sdk directory is getting included in the inspector package roots detection (if that is the Flutter SDK being used to build your app)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm that likely is the problem, I see my pub root directories are:

Screenshot 2025-01-24 at 1 40 14 PM

Because tool/flutter-sdk is under dev/devtools, everything there is included. Deleting /Users/elliottbrooks/dev/devtools so that the only entry is /Users/elliottbrooks/dev/devtools/packages fixes this.

I'll add details to the bug, and just have this PR add the launch config to devtools_app (it was annoying anyways that I could only launch the property editor from devtools root)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh actually I think I must have set that at some point 🤦‍♀️ When I delete both pub roots, and then use the auto-refresh button, it correctly adds only /Users/elliottbrooks/dev/devtools/packages. So I think we're okay here

},

]
}
Loading