Skip to content

Commit

Permalink
CI: Action - Code Analysis (#1101)
Browse files Browse the repository at this point in the history
  • Loading branch information
AmosHuKe authored Mar 9, 2024
1 parent b487b5d commit 347a0d1
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-example-apk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-java@v3
- uses: actions/setup-java@v4
with:
distribution: 'adopt'
java-version: '17'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-compatibility.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
with:
channel: 'stable'
cache: true
- uses: actions/setup-java@v3
- uses: actions/setup-java@v4
with:
distribution: 'adopt'
java-version: '17'
Expand Down
14 changes: 8 additions & 6 deletions .github/workflows/runnable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
os: [ ubuntu-latest ]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-java@v3
- uses: actions/setup-java@v4
with:
distribution: 'adopt'
java-version: '17'
Expand All @@ -62,8 +62,10 @@ jobs:
flutter --version
- name: Prepare dependencies
run: flutter pub get
- name: Analyse the repo
run: flutter analyze lib example/lib
- name: Check Dart code formatting
run: dart format . -o none --set-exit-if-changed
- name: Analyze Dart code
run: flutter analyze .
- name: Run tests
run: flutter test
- name: Generate docs
Expand All @@ -76,7 +78,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-java@v3
- uses: actions/setup-java@v4
with:
distribution: 'adopt'
java-version: '17'
Expand Down Expand Up @@ -106,7 +108,7 @@ jobs:
os: [ ubuntu-latest ]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-java@v3
- uses: actions/setup-java@v4
with:
java-version: '17'
distribution: 'adopt'
Expand All @@ -128,7 +130,7 @@ jobs:
os: [ macos-latest ]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-java@v3
- uses: actions/setup-java@v4
with:
distribution: 'adopt'
java-version: '17'
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ To know more about breaking changes, see the [Migration Guide][].
- Do not predicate subtypes images as adjusted on Darwin.
- Fix `PMProgressHandler` not getting notified when failed on Darwin.

### Improvements

- Improve code formatting.

## 3.0.0

### Breaking changes
Expand Down
4 changes: 2 additions & 2 deletions lib/src/filter/custom/advance.dart
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,9 @@ extension LogicalTypeExtension on LogicalType {
}

/// {@template PM.column_where_condition}
///
///
/// The where condition item for custom filter.
///
///
/// {@endtemplate}
abstract class WhereConditionItem {
/// The text of the condition.
Expand Down
2 changes: 1 addition & 1 deletion lib/src/filter/path_filter.dart
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class PMPathFilter {
/// For filter the [AssetPathEntity] on macOS and iOS.
///
/// Also see [PhotoManager.getAssetPathList]
///
///
/// {@endtemplate}
class PMDarwinPathFilter {
/// For type of the collection.
Expand Down

0 comments on commit 347a0d1

Please sign in to comment.