Flyte-core add missing imagePullSecrets support #4810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The console doesn't have / need a ServiceAccount, but it still needs credentials to be able to pull image from security registries Add a new imagePullSecrets value for that - The webhook ServiceAccount didn't have the correct imagePullSecrets set, so similarly could not pull images from security registries. Use the propeller settings Signed-off-by: ddl-ebrown <[email protected]>
dosubot
bot
added
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4810 +/- ##
===========================================
+ Coverage 58.98% 76.69% +17.71%
===========================================
Files 644 18 -626
Lines 55145 1515 -53630
===========================================
- Hits 32527 1162 -31365
+ Misses 20046 289 -19757
+ Partials 2572 64 -2508
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@davidmirror-ops this one should be a pretty straightforward bugfix |
pingsutw
approved these changes
Feb 5, 2024
| @@ -18,6 +18,10 @@ spec: | |||
| {{- end }} | |||
| labels: {{ include "flyteconsole.podLabels" . | nindent 8 }} | |||
| spec: | |||
| {{- with .Values.flyteconsole.imagePullSecrets }} | |||
| imagePullSecrets: | |||
There was a problem hiding this comment.
While I don't see this to be the most common scenario (hosting the flyteconsole image on a secured registry) I see it could be the case for more security-aware environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The console doesn't have / need a ServiceAccount, but it still needs credentials to be able to pull image from secured registries
Add a new imagePullSecrets value for that
The webhook ServiceAccount didn't have the correct imagePullSecrets set, so similarly could not pull images from security registries. Use the propeller settings
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link