Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyte-core add missing imagePullSecrets support #4810

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Flyte-core add missing imagePullSecrets support #4810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/flyte-core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ helm install gateway bitnami/contour -n flyte
| flyteconsole.image.pullPolicy | string | `"IfNotPresent"` | |
| flyteconsole.image.repository | string | `"cr.flyte.org/flyteorg/flyteconsole"` | Docker image for Flyteconsole deployment |
| flyteconsole.image.tag | string | `"v1.10.2"` | |
| flyteconsole.imagePullSecrets | list | `[]` | ImagePullSecrets to assign to the Flyteconsole deployment |
| flyteconsole.nodeSelector | object | `{}` | nodeSelector for Flyteconsole deployment |
| flyteconsole.podAnnotations | object | `{}` | Annotations for Flyteconsole pods |
| flyteconsole.podEnv | object | `{}` | Additional Flyteconsole container environment variables |
Expand Down
4 changes: 4 additions & 0 deletions charts/flyte-core/templates/console/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ spec:
{{- end }}
labels: {{ include "flyteconsole.podLabels" . | nindent 8 }}
spec:
{{- with .Values.flyteconsole.imagePullSecrets }}
imagePullSecrets:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't see this to be the most common scenario (hosting the flyteconsole image on a secured registry) I see it could be the case for more security-aware environments.

{{- toYaml . | nindent 8 }}
{{- end }}
securityContext:
runAsUser: 1000
fsGroupChangePolicy: "OnRootMismatch"
Expand Down
3 changes: 3 additions & 0 deletions charts/flyte-core/templates/propeller/webhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,9 @@ metadata:
annotations: {{ tpl (toYaml .) $ | nindent 4 }}
{{- end}}
{{- end }}
{{- with .Values.webhook.serviceAccount.imagePullSecrets }}
imagePullSecrets: {{ tpl (toYaml .) $ | nindent 2 }}
{{- end }}
---
# Create a binding from Role -> ServiceAccount
kind: ClusterRoleBinding
Expand Down
2 changes: 2 additions & 0 deletions charts/flyte-core/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,8 @@ flyteconsole:
tracking_id: "G-0QW4DJWJ20"
# -- Sets priorityClassName for flyte console pod(s).
priorityClassName: ""
# -- ImagePullSecrets to assign to the Flyteconsole deployment
imagePullSecrets: []

# It will enable the redoc route in ingress
deployRedoc: false
Expand Down
Loading