Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flyte-core rendering when flyteagent enabled #4922

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix flyte-core rendering when flyteagent enabled #4922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/flyte-core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ helm install gateway bitnami/contour -n flyte
| flyteagent.enabled | bool | `false` | |
| flyteagent.plugin_config.plugins.agentService.defaultAgent.endpoint | string | `"dns:///flyteagent.flyte.svc.cluster.local:8000"` | |
| flyteagent.plugin_config.plugins.agentService.defaultAgent.insecure | bool | `true` | |
| flyteagent.podLabels | object | `{}` | Labels for flyteagent pods |
| flyteconsole.affinity | object | `{}` | affinity for Flyteconsole deployment |
| flyteconsole.enabled | bool | `true` | |
| flyteconsole.ga.enabled | bool | `false` | |
Expand Down
2 changes: 2 additions & 0 deletions charts/flyte-core/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,8 @@ flyteagent:
defaultAgent:
endpoint: "dns:///flyteagent.flyte.svc.cluster.local:8000"
insecure: true
# -- Labels for flyteagent pods
podLabels: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ddl-ebrown I remove podLabels from the helper in this PR.

Also, would you mind taking a look at the new agent API? We want to make it as simple as possible, so make some change to it. flyteorg/flytekit#2146

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you remove podLabels just as a workaround for the chart install issue? In general, I think we want to keep that functionality (I added it recently in #4756)

Will have a look at the agent changes - thanks!

Copy link
Member

@pingsutw pingsutw Feb 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just as a workaround for the chart install issue

yes

I added it recently in #4756)

I see, got it. Let's merge your PR first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if there's any pending action on this PR?


#
# FLYTEPROPELLER SETTINGS
Expand Down
Loading