Fix flyte-core rendering when flyteagent enabled #4922
Conversation
dosubot
bot
added
size:XS
- Flyte agent now tries to render a specific set of podLabels, so
assumes that there is an empty `podLabels: {}` set. This change to
values.yaml for flyte-core ensures empty values are there.
- Fixes:
Error: template: flyte-core/charts/flyteagent/templates/agent/deployment.yaml:17:17: executing "flyte-core/charts/flyteagent/templates/agent/deployment.yaml" at <include "flyteagent.podLabels" .>: error calling include: template: flyte-core/templates/_helpers.tpl:122:16: executing "flyteagent.podLabels" at <.Values.flyteagent.podLabels>: nil pointer evaluating interface {}.podLabels
Signed-off-by: ddl-ebrown <[email protected]>
ddl-ebrown
force-pushed
the
fix-flytagent-defaults
branch
from
181d8ea to
f854f1e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4922 +/- ##
==========================================
- Coverage 58.92% 58.91% -0.02%
==========================================
Files 645 645
Lines 55394 55394
==========================================
- Hits 32640 32634 -6
- Misses 20171 20177 +6
Partials 2583 2583
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -279,6 +279,8 @@ flyteagent: | |||
| defaultAgent: | |||
| endpoint: "dns:///flyteagent.flyte.svc.cluster.local:8000" | |||
| insecure: true | |||
| # -- Labels for flyteagent pods | |||
| podLabels: {} | |||
There was a problem hiding this comment.
cc @ddl-ebrown I remove podLabels from the helper in this PR.
Also, would you mind taking a look at the new agent API? We want to make it as simple as possible, so make some change to it. flyteorg/flytekit#2146
There was a problem hiding this comment.
Did you remove podLabels just as a workaround for the chart install issue? In general, I think we want to keep that functionality (I added it recently in #4756)
Will have a look at the agent changes - thanks!
There was a problem hiding this comment.
just as a workaround for the chart install issue
yes
I added it recently in #4756)
I see, got it. Let's merge your PR first.
There was a problem hiding this comment.
Wondering if there's any pending action on this PR?
- Flyte agent now tries to render a specific set of podLabels, so
assumes that there is an empty `podLabels: {}` set. This change to
values.yaml for flyte-core ensures empty values are there.
- Fixes:
Error: template: flyte-core/charts/flyteagent/templates/agent/deployment.yaml:17:17: executing "flyte-core/charts/flyteagent/templates/agent/deployment.yaml" at <include "flyteagent.podLabels" .>: error calling include: template: flyte-core/templates/_helpers.tpl:122:16: executing "flyteagent.podLabels" at <.Values.flyteagent.podLabels>: nil pointer evaluating interface {}.podLabels
Signed-off-by: ddl-ebrown <[email protected]>
Flyte agent now tries to render a specific set of podLabels, so assumes that there is an empty
podLabels: {}set. This change to values.yaml for flyte-core ensures empty values are there.Fixes:
Error: template: flyte-core/charts/flyteagent/templates/agent/deployment.yaml:17:17: executing "flyte-core/charts/flyteagent/templates/agent/deployment.yaml" at <include "flyteagent.podLabels" .>: error calling include: template: flyte-core/templates/_helpers.tpl:122:16: executing "flyteagent.podLabels" at <.Values.flyteagent.podLabels>: nil pointer evaluating interface {}.podLabels
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link