Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(cache): Use AddRateLimited for batch enqueue #5228

Merged
merged 3 commits into from
Apr 12, 2024
+11 −6
Merged

perf(cache): Use AddRateLimited for batch enqueue #5228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
688702a
perf(cache): Use AddRateLimited for batch enqueue
pingsutw Apr 12, 2024
75cd64d
Fix tests
pingsutw Apr 12, 2024
399656f
lint
pingsutw Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flytestdlib/cache/auto_refresh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ func (w *autoRefresh) enqueueBatches(ctx context.Context) error {

for _, batch := range batches {
b := batch
w.workqueue.Add(&b)
w.workqueue.AddRateLimited(&b)
}

return nil
Expand Down
15 changes: 10 additions & 5 deletions flytestdlib/cache/auto_refresh_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,12 @@ import (
const fakeCacheItemValueLimit = 10

type fakeCacheItem struct {
val int
val int
isTerminal bool
}

func (f fakeCacheItem) IsTerminal() bool {
return false
return f.isTerminal
}

type terminalCacheItem struct {
Expand All @@ -42,11 +43,15 @@ func syncFakeItem(_ context.Context, batch Batch) ([]ItemSyncResponse, error) {
// After the item has gone through ten update cycles, leave it unchanged
continue
}

isTerminal := false
if item.val == fakeCacheItemValueLimit-1 {
isTerminal = true
}
items = append(items, ItemSyncResponse{
ID: obj.GetID(),
Item: fakeCacheItem{
val: item.val + 1,
val: item.val + 1,
isTerminal: isTerminal,
},
Action: Update,
})
Expand All @@ -60,7 +65,7 @@ func syncTerminalItem(_ context.Context, batch Batch) ([]ItemSyncResponse, error
}

func TestCacheFour(t *testing.T) {
testResyncPeriod := time.Millisecond
testResyncPeriod := 10 * time.Millisecond
rateLimiter := workqueue.DefaultControllerRateLimiter()

t.Run("normal operation", func(t *testing.T) {
Expand Down
Loading