Fix offline multiplayer in 1.16.4-1.16.5 #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves fn2006#150 If the game is launched in offline mode, pass invalid API servers via the -Dminecraft.api.* system properties. This workaround is mentioned here: FabricMC/fabric-loom#915 (comment) I think this change is appropriate to make here in PollyMC even though the Fabric developers decided against using it there. If a user wants to override the API servers back to the vanilla values (in order to use Auth Me or something), they can do so by setting the following custom JVM args on the instance: -Dminecraft.api.env=PROD -Dminecraft.api.auth.host=https://authserver.mojang.com -Dminecraft.api.account.host=https://api.mojang.com -Dminecraft.api.session.host=https://sessionserver.mojang.com -Dminecraft.api.services.host=https://api.minecraftservices.com Previously, auth args would override any user-specified args, but this patch also changes that behavior so user-specified args are now passed last.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #150
If the game is launched in offline mode, pass invalid API servers via the
-Dminecraft.api.*system properties. This workaround is mentioned here: FabricMC/fabric-loom#915 (comment)I think this change is appropriate to make here in PollyMC even though the Fabric developers decided against using it there. If a user wants to override the API servers back to the vanilla values (in order to use Auth Me or something), they can do so by setting the following custom JVM args on the instance:
Previously, auth args would override any user-specified args, but this patch also changes that behavior so user-specified args are now passed last.