Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDGPATRON-151 Modifying api contract for Post api of LC User registration #131

Merged
merged 10 commits into from
Oct 15, 2024

Conversation

Vignesh-kalyanasundaram
Copy link
Contributor

Purpose:
The purpose of the jira is to implement EDGPATRON-151

"description": "A flag to determine if a patron is activated/email verification completed.",
"type": "boolean",
"default": false
"description": "A boolean flag that indicates whether the patron has completed email verification. If this value is not provided when creating a new record, it will default to false.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also specify this "The value is required to be true for the Kiosk case of user registration since the email verification step is skipped in that scenario."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A boolean flag indicates if the patron has completed email verification. By default, this value is set to false when creating a new record. However, for Kiosk user registrations, this value should be sent true.

Maybe something like this

Copy link

@Vignesh-kalyanasundaram Vignesh-kalyanasundaram merged commit d6ff358 into master Oct 15, 2024
8 checks passed
@Vignesh-kalyanasundaram Vignesh-kalyanasundaram deleted the EDGPATRON-151 branch October 15, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants