Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDGPATRON-151 Modifying api contract for Post api of LC User registration #131

Merged
merged 10 commits into from
Oct 15, 2024
Merged

EDGPATRON-151 Modifying api contract for Post api of LC User registration #131

Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
960ac8d
EDGPATRON-151 Adding new api contract for Post and get api of LC User…
Vignesh-kalyanasundaram Oct 11, 2024
3414392
EDGPATRON-151 Adding new api contract for Post and get api of LC User…
Vignesh-kalyanasundaram Oct 11, 2024
9b1a6d7
EDGPATRON-151 Adding new api contract for Post and get api of LC User…
Vignesh-kalyanasundaram Oct 11, 2024
4d616bc
EDGPATRON-151 Adding new api contract for Post and get api of LC User…
Vignesh-kalyanasundaram Oct 11, 2024
f78d6f0
Merge branch 'master' of github.com:folio-org/edge-patron into EDGPAT…
Vignesh-kalyanasundaram Oct 14, 2024
e31cca3
EDGPATRON-151 Modifying api contract for Post api of LC User registra…
Vignesh-kalyanasundaram Oct 14, 2024
ec04a29
EDGPATRON-151 Modifying api contract for Post api of LC User registra…
Vignesh-kalyanasundaram Oct 15, 2024
ad79359
Merge branch 'master' of github.com:folio-org/edge-patron into EDGPAT…
Vignesh-kalyanasundaram Oct 15, 2024
f827856
EDGPATRON-151 Modifying api contract for Post api of LC User registra…
Vignesh-kalyanasundaram Oct 15, 2024
97925c0
EDGPATRON-151 Modifying api contract for Post api of LC User registra…
Vignesh-kalyanasundaram Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions ramls/staging_user.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,13 @@
"type": "object",
"properties": {
"isEmailVerified": {
"description": "A flag to determine if a patron is activated/email verification completed.",
"type": "boolean",
"default": false
"description": "A boolean flag that indicates whether the patron has completed email verification. If this value is not provided when creating a new record, it will default to false.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also specify this "The value is required to be true for the Kiosk case of user registration since the email verification step is skipped in that scenario."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A boolean flag indicates if the patron has completed email verification. By default, this value is set to false when creating a new record. However, for Kiosk user registrations, this value should be sent true.

Maybe something like this

"type": "boolean"
},
"status": {
"description": "Status of the patron, whether TIER-1 or TIER-2.",
"description": "Represents the patron's tier status, which can be either TIER-1 or TIER-2. If this value is not provided when creating a new record, the default status will be set to TIER-1.",
"type": "string",
"enum": ["TIER-1", "TIER-2"],
"default": "TIER-1"
"enum": ["TIER-1", "TIER-2"]
},
"generalInfo": {
"type": "object",
Expand Down
Loading