STCOM-1348 Keyboard shortcut modal missing scrollbar.

[JohnC-80]

STCOM-1348

During refactor of our modals, an inline style was added, hiding the overflow of the content div. This PR just removes that inline style. Tested with the ui-plugin-find-users modal as well as the applicable keyboard shortcuts modal.

[github-actions]

Bigtest Unit Test Results

    1 files  ±0      1 suites  ±0   14s ⏱️ ±0s
1 521 tests ±0  1 513 ✅ ±0  8 💤 ±0  0 ❌ ±0 
1 523 runs  ±0  1 515 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 0ba8bfe. ± Comparison against base commit d66b253.

♻️ This comment has been updated with latest results.

[zburke]

@JohnC-80, this PR explains the solution (remove the offending style={{ overflow: 'hidden' }} line) but it would be nice to know why that line was added in the first place in STCOM-1334/PR #2341. Indisputably, it causes the scroll problem, but presumably it solved some problem as well. Will that problem now resurface or are you confident it's just cruft?

[JohnC-80]

I'm pretty confident of cruft here. It was not present on the modal content pre-refactor, conflicts with the overflow: auto built-in styling of ModalContent and there's no logical cause in the code. Likely, it was added for testing/ensuring Overlay problems/functionality in a pre- #2351 world.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud