Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOM-1348 Keyboard shortcut modal missing scrollbar. #2354

Merged
merged 3 commits into from
Oct 1, 2024
Merged

STCOM-1348 Keyboard shortcut modal missing scrollbar. #2354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ebd46a
remove inline style from modal content
JohnC-80 Sep 30, 2024
8283330
log change
JohnC-80 Sep 30, 2024
0ba8bfe
Merge branch 'master' into STCOM-1348
JohnC-80 Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
* `<AccordionHeaders>` are wrapped with a div for use as a HotKeys ref. Refs STCOM-1343.
* Use whole `dataOptions` array for memoization dependency rather that just `length` property. STCOM-1346.
* Default the scope of `<CommandList>` to `document.body`. Remove internal wrapping div. Refs STCOM-1351.
* Remove inline styling from `<Modal>` content. Refs STCOM-1348.

## [12.1.0](https://github.com/folio-org/stripes-components/tree/v12.1.0) (2024-03-12)
[Full Changelog](https://github.com/folio-org/stripes-components/compare/v12.0.0...v12.1.0)
Expand Down
1 change: 0 additions & 1 deletion lib/Modal/Modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,6 @@ const Modal = forwardRef((props, ref) => {
<div
className={getContentClass()}
id={id && `${id}-content`}
style={{ overflow: 'hidden' }}
ref={contentRef}
>
{/* so that aria-labels will still announce if aria-labelledby is also provided */}
Expand Down
Loading