Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STSMACOM-849: Add showSortIndicator prop to SearchAndSort to display sort indicator next to the column names. #1500

Merged
merged 2 commits into from
Aug 14, 2024
Merged

STSMACOM-849: Add showSortIndicator prop to SearchAndSort to display sort indicator next to the column names. #1500

merged 2 commits into from
Aug 14, 2024

Conversation

Dmytro-Melnyshyn
Copy link
Contributor

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Aug 13, 2024 •
edited
Loading

Description

Add showSortIndicator prop to SearchAndSort to display sort indicator next to the column names.

Issues

STSMACOM-849

Related PRs

folio-org/stripes-components#2333

Screencast

image

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested review from BogdanDenis and a team August 13, 2024 13:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 13, 2024 •
edited
Loading

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit da49a2b. ± Comparison against base commit ba72ce0.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 13, 2024 •
edited
Loading

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   14s ⏱️ -2s
498 tests ±0  461 ✔️ +1  37 💤 ±0  0 ❌  - 1 
500 runs  ±0  463 ✔️ +1  37 💤 ±0  0 ❌  - 1 

Results for commit da49a2b. ± Comparison against base commit ba72ce0.

♻️ This comment has been updated with latest results.

@Dmytro-Melnyshyn Dmytro-Melnyshyn mentioned this pull request Aug 13, 2024
Merged
@artem-blazhko artem-blazhko requested a review from a team August 14, 2024 12:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit 272db11 into master Aug 14, 2024
5 of 6 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the STSMACOM-849 branch August 14, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BogdanDenis BogdanDenis BogdanDenis approved these changes

@artem-blazhko artem-blazhko artem-blazhko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dmytro-Melnyshyn @BogdanDenis @artem-blazhko