Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-2486 Added support for containsAny match option in Advanced search #2324

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

BogdanDenis
Copy link
Contributor

@BogdanDenis BogdanDenis commented Oct 30, 2023

Description

Added support for containsAny match option in Advanced search

Screenshots

chrome_soEjTfa0jk.mp4

Issues

UIIN-2486

Related PRs

folio-org/stripes-smart-components#1409
folio-org/stripes-components#2162

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Jest Unit Test Statistics

    1 files  ±0  226 suites  ±0   12m 11s ⏱️ -48s
888 tests ±0  886 ✔️ ±0  2 💤 ±0  0 ±0 
893 runs  ±0  891 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit f6858df. ± Comparison against base commit 3d7c603.

♻️ This comment has been updated with latest results.

@BogdanDenis BogdanDenis marked this pull request as ready for review October 30, 2023 15:33
},
contributor: {
exactPhrase: 'contributors.name=="%{query.query}"',
containsAll: 'contributors.name="*%{query.query}*"',
startsWith: 'contributors.name="%{query.query}*"',
containsAny: 'contributors.name any "*%{query.query}*"',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contributors.name is a term field, any operator can be used only for a full text field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed it with Christine and she said that we should perform the search anyways even if there are no results

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@BogdanDenis BogdanDenis merged commit e83ab07 into master Oct 31, 2023
4 checks passed
@BogdanDenis BogdanDenis deleted the UIIN-2486 branch October 31, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants