Format string in output file with plain line-ending character instead of os.linesep #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue only affects Windows PowerShell. In some files written by Meeko, each line has double the line-ending characters. This is likely because the Python built-in function
f.open()
by default translates '\r\n' (os.linesep on Windows) to '\r\r\n' when writing the file, which will be read as '\n\n' when the file is re-opened.https://docs.python.org/3/library/functions.html#open
This PR replaces all eol by the plain line-ending character '\n'. Another possible solution is to always write without translation, i.e. f.open(newline='') but that isn't the default. Thanks to Nicole Benson (Fuchs lab, OSU) for bringing this to our attention.