Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8727: fix panel component not showing label in data grid #114

Merged

Conversation

ZenMasterJacob20011
Copy link
Contributor

@ZenMasterJacob20011 ZenMasterJacob20011 commented Dec 5, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8727

Description

What changed?

Changed the if condition for panels showing labels from ctx.component.hideLabel to ctx.label.hidden

Why have you chosen this solution?

ctx.label.hidden has additional checks upstream to determine if a label is hidden or not. We need these checks so that "Show Label in DataGrid" works as expected

Breaking Changes / Backwards Compatibility

N/A

Dependencies

N/A

How has this PR been tested?

Wrote a test in formio.js formio/formio.js#5937

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio johnformio merged commit 978bf99 into main Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants