Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8727: created test for FIO-8727 #5937

Conversation

ZenMasterJacob20011
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8727

Description

What changed?

Wrote some tests

Why have you chosen this solution?

To prevent regressions

Breaking Changes / Backwards Compatibility

N/A

Dependencies

The tests will fail until formio.js uses a version of bootstrap that has the below pull request pulled in
formio/bootstrap#114

How has this PR been tested?

manually and automated test

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@ZenMasterJacob20011 ZenMasterJacob20011 force-pushed the FIO-8727-fix-panel-component-not-showing-label-in-data-grid-test branch 2 times, most recently from 5774880 to 4e60150 Compare December 16, 2024 23:47
@ZenMasterJacob20011 ZenMasterJacob20011 force-pushed the FIO-8727-fix-panel-component-not-showing-label-in-data-grid-test branch from 4e60150 to 3653f1b Compare December 17, 2024 00:56
@ZenMasterJacob20011 ZenMasterJacob20011 force-pushed the FIO-8727-fix-panel-component-not-showing-label-in-data-grid-test branch from 734e9a3 to a96ef5d Compare December 17, 2024 18:37
@johnformio johnformio merged commit c7bfc28 into master Dec 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants