FIO-9176: fix component path in error info #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
johnformio
reviewed
Oct 22, 2024
src/process/validation/index.ts
Outdated
Comment on lines
154
to
156
| if(component.parent){ | ||
| cleanedError.context.path = absolutePath; | ||
| } |
There was a problem hiding this comment.
What is the behavior when the component is not in a parent? Is there a test for that case?
Comment on lines
+176
to
179
| if (component.parent) { | ||
| cleanedError.context.path = absolutePath; | ||
| } | ||
| cleanedError.context.path = absolutePath; |
There was a problem hiding this comment.
This change doesn't make sense to me. It seems to me that the path field will always be absolute path. What am I missing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9176
Description
Removed path override in scope.error for components without parent. This allows to get full path to components inside components such as edit grid and avoid an error when there are components with same key inside and outside edit grid component.
Dependencies
formio/formio.js#5867
How has this PR been tested?
autotests
manually
Checklist: