FIO-7514: fixed an isse where new simple conditionals do not work when condition is based on the value of resource select with object value #5429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… condition is based os the value of resource select with object value
6 tasks
|
Can you resolve the merge conflict and I believe tests should pass now with master pulled in. |
…ect-resource-with-object-value
lane-formio
pushed a commit
that referenced
this pull request
Dec 22, 2023
…ls-for-select-resource-with-object-value FIO-7514: fixed an isse where new simple conditionals do not work when condition is based on the value of resource select with object value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-7514
Description
What changed?
When the resource select with object value (select with reference, select resource without value property or select resource with 'entire object' value property) is used in the new conditional logic, we suppose that user expects the equality of labels of the value in condition and the actual value of the select component. This PRs makes so the select component label data is saved as a value for the condition and than compared with the label data of the actual select value.
Why have you chosen this solution?
Discussed with Travis as best solution for this use case.
Dependencies
formio/formio#1664
How has this PR been tested?
Manually + added tests
All tests passed locally
Checklist: