Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7514: fixed an issue where submission reference object is not attached to the value of select component with reference enabled #1664

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Dec 4, 2023

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7514

Description

What changed?

When the subrequest for reference submission is made, the submissionId param of the main submission request overrides the reference subId and the submission subrequest returns the 404 error. This PR unsets submissionId param from subrequest to prevent this situation.

formio/formio.js#5429

How has this PR been tested?

Manually

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

…ached to the value of select component with reference enabled
@brendanbond brendanbond merged commit 01d2497 into master Dec 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants