Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7580,6475: fixed error events issues and an issue where general server errors quickly disappear from ui #5472

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Jan 23, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7580

Description

What changed?

This PR:

  • reverts changes made by PR 0043531 (FIO-6475). Those change prevented the emission of error event on submit of invalid form;
  • fixes the original issue (FIO-6475) where server errors (that are not related to the server validation of the component) are not persistent in ui;
  • adds an argument for the submitError event in case when submission is failed due to front-end validation

How has this PR been tested?

Manually + added tests

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@travist
Copy link
Member

travist commented Jan 31, 2024

👍

@travist travist merged commit 0b16a90 into master Jan 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants