Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved Issue #14 : Add Russian and Ukrainian as active languages #50

Closed
wants to merge 10 commits into from
Closed

Solved Issue #14 : Add Russian and Ukrainian as active languages #50

wants to merge 10 commits into from

Conversation

Darkboy17
Copy link
Contributor

This PR closes/references issue #14.

How has this been tested?

I have fixed the issue as requested by adding the two languages, "Russian" and "Ukranian" to the Active language list.

Please take a look at the screenshot of the newly added languages.

activelanguages

To ensure if the languages can be translated, please have a look at the screenshot where I have selected "Russian" as underlined.

lang_sel_russian

Now to confirm, when I visit the link http://127.0.0.1:8000/orga/event/, it takes me to a page as shown in the screenshot below, which successfully translated the language to Russian.

page_russian_translated

Now, let us test for the language "Ukranian" by similarly following the above steps.
Selecting "Ukranian" as shown in the screenshot below

lang_sel_ukr

Similarly, when I visit http://127.0.0.1:8000/orga/event/, I get the page in Ukranian as shown in the screenshot below.

page_ukr_translated

Checklist

  • I have manually tested the functionality to cover my changes.
  • I have strictly followed the contribution guidelines and best practices.

@norbusan
Copy link
Member

This is the same mess of a PR as the previous. Look at the commit.
image
Why are my commits, that are in development already, included in the PR?
Why are other issues included in the PR?

Can you please follow the advise I gave you and ONLY include the changes that are necessary?

@Darkboy17
Copy link
Contributor Author

Norbusan, I'm sorry for the carelessness.

In my first PR, I just worked on code and then commit and push my changes.
Next, on github I visited the pull requests page, clicked on "Compare & Pull" and then "Create Pull Request".

Below is the screenshot of my first PR.
Screenshot 2024-02-20 at 19-28-42 Issue #17 fixed by Darkboy17 · Pull Request #38 · fossasia_eventyay-talk

As you can see, there's only one commit.

For the next issue I followed the same steps as mentioned above, but don't know why for some reason, many commits are happening when only my commits should be visible.

Am I missing something important here? Do I need to follow different steps for second PRs and onwards?

As for the recent advice you gave, I have cherry picked only the changes that are necessary and wasn't expecting to get the same mess.

Maybe I am missing something important here

@Darkboy17
Copy link
Contributor Author

Can I just close all the messed PRs and start with a new PR? This time I'll be very careful.

@Darkboy17
Copy link
Contributor Author

I'll close all the messed up PRs for now.

@Darkboy17 Darkboy17 closed this Feb 21, 2024
@Darkboy17 Darkboy17 deleted the issue#14_branch branch February 21, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants