fix: honour currency precision while fetching balance

[rtdany10]

GL Balance:

GL Balance as per Bank Reco Statement:

When multi-currency is involved, entries are made with decimals containing more than currency_precision. Which in turn causes difference as shown above. We should have a validation in GL Entry to trim off extra decimals. Thoughts?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f1e729) 60.14% compared to head (93681cf) 60.15%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #38218   +/-   ##
========================================
  Coverage    60.14%   60.15%           
========================================
  Files          757      757           
  Lines        70696    70697    +1     
========================================
+ Hits         42523    42527    +4     
+ Misses       28173    28170    -3     

Files	Coverage Δ
erpnext/accounts/utils.py	74.47% <100.00%> (+0.03%)	⬆️

... and 2 files with indirect coverage changes

[barredterra]

Shouldn't we round the output of the calculation instead of the input?

return flt(bal, precision)

This is also a bit more robust than formatting query strings.

[rtdany10]

Shouldn't we round the output of the calculation instead of the input?

Tried that, but mismatch still occurred in GL and Bank Reco Statemaent.
Rounded sum may not always be same as sum of rounded values.

We shouldn't ideally be storing more decimals in GL Entries than required tbh.

[barredterra]

Okay, makes sense. In this case, let's at least use SQL parameters instead of f-strings?

[barredterra]

What you did is still python string formatting, not SQL params. ;)

What I meant was passsing the values here https://github.com/frappe/frappe/blob/3ed363a27dee14efa3e070bff4a57fa7c2a366bf/frappe/database/database.py#L147-L150

[rtdany10]

What you did is still python string formatting, not SQL params. ;)

What I meant was passsing the values here https://github.com/frappe/frappe/blob/3ed363a27dee14efa3e070bff4a57fa7c2a366bf/frappe/database/database.py#L147-L150

Sorry my bad, rest of the code was in that structure which is why I got confused.
I've made the changes, please do check

[stale]

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

[rtdany10]

@ruthra-kumar @deepeshgarg007

[stale]

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

[stale]

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

[rtdany10]

@deepeshgarg007

[stale]

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

[rtdany10]

@ruthra-kumar @deepeshgarg007 🥺